-
Notifications
You must be signed in to change notification settings - Fork 148
Override upload file max size in mb #2370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Override upload file max size in mb #2370
Conversation
Thanks for the pull request, @MuPp3t33r! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@MuPp3t33r Thanks for your detailed PR description. I've approved the tests to run here and will await @bradenmacdonald 's review. |
@MuPp3t33r I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard? |
@MuPp3t33r Thanks for the revised version here, and especially for the nice testing instructions! I will try to review this shortly. In the meantime, would you mind addressing these minor lint issues? And as @e0d mentioned, we need the commits to start with |
Original configuration had a hard-coded limit of 20MB per file supplied to the platform. This change will retain the existing 20MB limit as default, but provide the admin with the ability to override the value via the MFE_CONFIG API (getConfig) The new function includes validation to check that the override value supplied is in fact a valid and positive integer and reverts to default 20MB in case of validation failure
Originally the constant 'maxFileSize' was hardcoded to 20MB and was not configured to use the pre-existing value defined in constants.js This fix removes the hardcoded value and calls the function getUploadFileMaxSize() to determine the value of maxFileSize
This change allows the ModalDropzone to fetch the maximum allowed size via a call to getUploadFileMaxSize() defined in constants. Additionally fixes the conversion factor (maxSize/(1024*1024) vs (1000*1000) for consistency with upstream code
This change allows the TextbookForm to fetch the maximum allowed size via a call to getUploadFileMaxSize() defined in constants. Additionally fixes the conversion factor (maxSize/(1024*1024) vs (1000*1000) for consistency with upstream code
694830e
to
6b60d91
Compare
@e0d @bradenmacdonald |
I've run them. |
For attention to @bradenmacdonald to review if this PR meets requirements.
Description
This update makes the following changes:
constants.js
:FilePage.jsx
:maxFileSize
value and instead import it from constants.jsModalDropzone.jsx
:UPLOAD_FILE_MAX_SIZE
constants that were defined and replaced with a call to the new function inconstants.js
TextbookForm.jsx
:UPLOAD_FILE_MAX_SIZE
constants that were defined and replaced with a call to the new function inconstants.js
Imports from constants now use the updated new format
'@src/constants'
instead of the old'../../constants'
Supporting information
this is an improvement to my previous attempt before i really knew what i was doing, now I only know a little bit of what I'm doing :)
Testing instructions
Note that this must be done in MFE_CONFIG and in the CaddyFile to allow Caddy to process your larger requests
Here is a sample plugin allowing user to provide one input for the value and it applies in both locations
tutor plugins enable override_max_asset_upload_size
tutor local stop && tutor local start -d
Now, under the following menus:
You will find that you can upload files up to whatever maximum defined in the
override_max_asset_upload_size
plugin